Make field nulalble

rommapp · Jan 11, 2025 · e84f7af · e84f7af
1 parent b5d2cad
commit e84f7af
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/backend/endpoints/responses/rom.py b/backend/endpoints/responses/rom.py
@@ -121,7 +121,7 @@ class RomSchema(BaseModel):
     # Metadata fields
     first_release_date: int | None
     youtube_video_id: str | None
-    average_rating: float
+    average_rating: float | None
     alternative_names: list[str]
     genres: list[str]
     franchises: list[str]

diff --git a/backend/models/rom.py b/backend/models/rom.py
@@ -171,7 +171,7 @@ def first_release_date(self) -> int:
         return 0
 
     @property
-    def average_rating(self) -> float:
+    def average_rating(self) -> float | None:
         igdb_rating = (
             float(self.igdb_metadata.get("total_rating", 0))
             if self.igdb_metadata
@@ -182,9 +182,10 @@ def average_rating(self) -> float:
             if self.moby_metadata
             else 0.0
         )
-        ratings = [igdb_rating, moby_rating * 10]  # Moby rating is out of 10
 
-        return sum(ratings) / len([r for r in ratings if r]) if any(ratings) else 0.0
+        ratings = [r for r in [igdb_rating, moby_rating * 10] if r != 0.0]
+
+        return sum(ratings) / len([r for r in ratings if r]) if any(ratings) else None
 
     @property
     def genres(self) -> list[str]:

diff --git a/frontend/src/__generated__/models/DetailedRomSchema.ts b/frontend/src/__generated__/models/DetailedRomSchema.ts
diff --git a/frontend/src/__generated__/models/RomSchema.ts b/frontend/src/__generated__/models/RomSchema.ts
diff --git a/frontend/src/__generated__/models/SimpleRomSchema.ts b/frontend/src/__generated__/models/SimpleRomSchema.ts