-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added custom name for platforms #1383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurdi15
added
feature
New feature or request
ui/ux
UI/UX improvements or suggestions
labels
Dec 24, 2024
Test Results92 tests 92 ✅ 26s ⏱️ Results for commit f24c06f. ♻️ This comment has been updated with latest results. |
gantoine
requested changes
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you rebase the PR to remove all the code for rom multi-select?
frontend/src/components/Gallery/AppBar/Platform/PlatformInfoDrawer.vue
Outdated
Show resolved
Hide resolved
gantoine
force-pushed
the
feat/platforms-custom-name
branch
from
December 24, 2024 15:24
eace2f7
to
6c238a8
Compare
gantoine
approved these changes
Dec 24, 2024
…as and update related components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now platforms can have a custom name, editing it from the platform info panel