Routing routine can cope with question marks #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The routing routine failed when e.g. a third party added normal "question mark GET parameters" to the URL. With this commit these parameters are removed before the URL parts are seperated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The routing routine failed when e.g. a third party added normal "question mark GET parameters" to the URL. With this commit these parameters are removed before the URL parts are separated.
I had this problem when I integrated for example the Facebook login. After the login of the user Facebook will redirect him or her to [myURL]?code=[someHash] and this used to break PIPs routing system.