Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty docstrings #151

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Fix empty docstrings #151

merged 1 commit into from
Jul 6, 2022

Conversation

jumcorredorro
Copy link
Contributor

@jumcorredorro jumcorredorro commented Jul 5, 2022 •
edited
Loading

Description

Add missing docstrings.

Closes issue(s)

#43

Screenshots (if appropriate)

Changes include

  • Bugfix (non-breaking change that solves an issue, bump the third digit of the version)
  • New feature (non-breaking change that adds functionality, bump the second digit of the version)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality, bump the first digit of the version)
  • Documentation update (Don't bump the version of the project)

Other comments

@jumcorredorro jumcorredorro linked an issue Jul 5, 2022 that may be closed by this pull request
Review docstrings #43
Open
@jumcorredorro jumcorredorro marked this pull request as ready for review July 5, 2022 19:09
@jumcorredorro jumcorredorro requested a review from a team as a code owner July 5, 2022 19:09
@jumcorredorro jumcorredorro requested review from brunomichetti, martinjaimem, JorgeMichelena, malexandroff1 and MathiasLantean and removed request for a team and martinjaimem July 5, 2022 19:09
brunomichetti
brunomichetti approved these changes Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@brunomichetti brunomichetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change the docs?
Have you tested this?

jumcorredorro
jumcorredorro commented Jul 6, 2022
View reviewed changes
Copy link
Contributor Author

@jumcorredorro jumcorredorro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brunomichetti yes, branches that starts with docs/ run a validation on documentation. Please take a look into checks and you will see the job. 🚀

malexandroff1
malexandroff1 approved these changes Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@malexandroff1 malexandroff1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@jumcorredorro jumcorredorro merged commit fb4b20a into develop Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malexandroff1 malexandroff1 malexandroff1 approved these changes

@brunomichetti brunomichetti brunomichetti approved these changes

@JorgeMichelena JorgeMichelena Awaiting requested review from JorgeMichelena

@MathiasLantean MathiasLantean Awaiting requested review from MathiasLantean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review docstrings
3 participants
@jumcorredorro @brunomichetti @malexandroff1