feature/55 first approach to campaigns #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-ignacio-sanchez
requested review from
nsantos16,
kaozdl,
brunomichetti,
MathiasLantean,
martinjaimem and
JorgeMichelena
| from drip.models import Drip | ||
| from campaigns.models import Campaign, CampaignDrip | ||
|
|
||
| DRIP_AMOUNT = 10 |
There was a problem hiding this comment.
I would use random.randint. Just a suggestion
brunomichetti
previously requested changes
Dec 18, 2020
| DRIP_AMOUNT = 10 | ||
|
|
||
|
|
||
| class DripsTestCase(TestCase): |
There was a problem hiding this comment.
Please test also using a class different from Drip, to test the GenericForeignKey part
kaozdl
reviewed
Dec 22, 2020
campaigns/models.py
Outdated
Comment on lines
15
to
17
| return Drip.objects.filter( | ||
| id__in=self.campaign_drips.values_list('id', flat=True) | ||
| ) |
There was a problem hiding this comment.
This should be a model manager to maintain the django interface
|
Looks good so far, keep in mind what we discussed 🚀 |
juan-ignacio-sanchez
changed the title
juan-ignacio-sanchez
dismissed
brunomichetti’s stale review
This does not make sense anymore since I've changed implementation
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a new Model called "Campaign" that groups Drips through the CampaignDrip intermediate Model. Also allows the lib's user to configure the Drip Model to be used.
Closes issue(s)
Screenshots (if appropriate)
Changes include