Upgrade to React Native 0.73.5 #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandatoledo
requested review from
asdolo,
jpirazusta and
juanchoperezj
and removed request for
asdolo and
jpirazusta
fernandatoledo
requested review from
ManuViola77,
tamarasuarezrod and
guillermomachado
fernandatoledo
requested review from
nicmalegre,
Stukz,
marcos09 and
ramirogavagnin
juanchoperezj
previously approved these changes
Mar 8, 2024
rnb-cli/src/tools/react-native.ts
Outdated
| @@ -98,11 +98,11 @@ export async function renameReactNativeApp( | |||
| `android/app/_BUCK`, | |||
| `android/app/BUCK`, | |||
| `android/app/build.gradle`, | |||
| `android/app/src/debug/java/${newPath}/ReactNativeFlipper.java`, | |||
| // `android/app/src/debug/java/${newPath}/ReactNativeFlipper.java`, | |||
There was a problem hiding this comment.
Is this comment intended?
There was a problem hiding this comment.
Great! I deleted the commented line, that file is not necessary anymore on RN 0.73: https://react-native-community.github.io/upgrade-helper/?from=0.72.5&to=0.73.5
JUNIOR140889
approved these changes
Mar 12, 2024
juanchoperezj
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Description
The React Native version was upgraded to 0.73.5 (last stable version) using the React Native Upgrade Helper Diff
Notes:
Tasks:
Preview