fix(ci): docs not being deployed automatically when releasing a new template version #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdolo
requested review from
marcos09,
fernandatoledo,
juanchoperezj and
guillermomachado
💯 Test Coverage
😎 Tests Results
👀 Tests Details • (51%)
|
fernandatoledo
approved these changes
Dec 6, 2024
juanchoperezj
approved these changes
Dec 6, 2024
asdolo
deleted the
fix/ci_docs_not_being_deployed_when_releasing_a_new_template_version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR fixes a bug in the
new-template-version.ymlworkflow that preventeddeploy-docs.ymlworkflow not to trigger automatically. It also replaces the old classicGH_TOKENtoken with a modern fine-grained token (NEW_TEMPLATE_VERSION_PAT).The problem was that the old token didn't have enough permissions to trigger another workflow.
Why did you do this?
To fix this bug, which was introduced in this PR.
Who/what does this impact?
It affects the documentation deployment process. It also impacts people reading the documentation, who will now be reading the version corresponding to the latest version of the template.
How did you test this?
I pushed this changes in a private fork and ensured both workflows ran as expected.