fix: eas build devclient #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandatoledo
requested review from
marcos09,
asdolo,
juanchoperezj and
guillermomachado
💯 Test Coverage
😎 Tests Results
👀 Tests Details • (52%)
|
guillermomachado
approved these changes
Jan 15, 2025
asdolo
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds missing expo-dev-client plugin to app.js, this plugin is required to be able to build using eas build correctly. https://docs.expo.dev/versions/latest/sdk/dev-client/#example-appjson-with-config-plugin
Why did you do this?
Eas build was finishing successfully and eas update too, but when was needed to install the app in a device it said that it was not a valid version.
Who/what does this impact?
Eas builds and updates
How did you test this?
Using eas build and eas update and installing the app on a physical iOS device.