fix(cli): remove docs & CLI deploy workflows #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdolo
requested review from
marcos09,
fernandatoledo,
juanchoperezj and
guillermomachado
and removed request for
a team
💯 Test Coverage
😎 Tests Results
👀 Tests Details • (51%)
|
fernandatoledo
approved these changes
Sep 10, 2024
asdolo
force-pushed
the
refactor/cli_move_file_operations_to_project_files_manager_class
branch
from
0a34d29 to
29594e4
Compare
asdolo
force-pushed
the
fix/cli_remove_docs_cli_deploy_workflows
branch
from
9ea37f7 to
a3404e5
Compare
Base automatically changed from
refactor/cli_move_file_operations_to_project_files_manager_class
to
master
September 10, 2024 18:54
guillermomachado
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Remove
.github/workflows/deploy-cli.ymland.github/workflows/deploy-docs.ymlfiles as part of the project setup process.Why did you do this?
Because it doesn't make sense to have those workflows in the context of a project.
Who/what does this impact?
N/A
How did you test this?
Locally ran the CLI to create a new project and verifying that the mentioned files were not present.