fix(cli): set project name in README and Expo config #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdolo
requested review from
marcos09,
fernandatoledo,
juanchoperezj and
guillermomachado
and removed request for
a team
💯 Test Coverage
😎 Tests Results
👀 Tests Details • (51%)
|
fernandatoledo
approved these changes
Sep 10, 2024
asdolo
force-pushed
the
fix/cli_remove_warning_from_pull_request_template
branch
from
fc0813e to
741647f
Compare
asdolo
force-pushed
the
fix/cli_set_project_name_in_readme_and_expo_config
branch
from
bdf6820 to
5f0eda4
Compare
Base automatically changed from
fix/cli_remove_warning_from_pull_request_template
to
master
September 10, 2024 20:29
guillermomachado
approved these changes
Sep 11, 2024
asdolo
deleted the
fix/cli_set_project_name_in_readme_and_expo_config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Add project name to README and add project slug to Expo config as part of the project setup process.
Why did you do this?
Because otherwise newly created apps will still have the default app name.
Who/what does this impact?
This should only affect new projects.
How did you test this?
Locally running the CLI to create a new project and verifying that the project README file has now the project name, and that Expo config contains the lowercased project name as slug.