Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guess_readme() matches a single README file #191

Merged
merged 2 commits into from
Oct 12, 2018

Conversation

bastistician
Copy link
Contributor

Fixes #189 and fixes #190.

guess_readme() now matches README.Rmd and README.md as well as their lower-/mixed-case variants (including readme.rmd which hasn't been matched before), but no other files such as README.Rmd~ or DO_NOT_README.md. The function either returns a single readme_path or NULL. I have added an appropriate test for this behaviour.

In the rare event where there exist multiple mixed-case README.md files on Unix-alikes, the function returns the first match (which is locale-dependent). I have decided not to warn about that since codemetar is generally non-verbose about its guesses.

I've also added myself to the DESCRIPTION using desc::desc_add_me() as suggested by @maelle (#190 (comment)).

@maelle
Copy link
Member

maelle commented Oct 12, 2018

Thanks a lot @bastistician! I see the failure on Travis is due to rOpenSci review badges and underlines the need for #175.

ignore.case = TRUE is so elegant! And I'm glad desc::desc_add_me() worked 😸

@maelle maelle merged commit 44236ea into ropensci:dev Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants