Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try() and pass Github token to gh::gh() (related to #175) #198

Closed
wants to merge 2 commits into from

Conversation

mrustl
Copy link
Contributor

@mrustl mrustl commented Nov 29, 2018

The changes done are related to #175.

As I frequently hit Github`s API limit for my use case I passed the Github token as additional argument to gh::gh() for issues/topics/readme and also added the missing try() as requested by @maelle for the issue/topic parts.

Finally I updated the package documentation with pkgdown.

@cboettig
Copy link
Member

LGTM. @maelle I'll let you look over and merge this.

@maelle Unrelated but we could also consider relaxing our codecov targets so that they don't throw failed checks for small decreases in total test coverage like this... (I just learned how to do this over in RNeXML, check out the codecov.yml there)

@maelle
Copy link
Member

maelle commented Nov 30, 2018

@mrustl thanks! We haven't updated our contributing guidelines but the active branch is actually dev, could you PR to dev?

@maelle
Copy link
Member

maelle commented Nov 30, 2018

Also note that one can also save the token as an environment variable called GITHUB_PAT in which case gh will use it. :-)

@mrustl mrustl changed the base branch from master to dev November 30, 2018 08:43
@mrustl
Copy link
Contributor Author

mrustl commented Nov 30, 2018

@maelle done! However, I don't know how I can see/fix what's causing the conflict in "guess_metadata.R"

@maelle
Copy link
Member

maelle commented Nov 30, 2018

Thanks but have you really changed 36 files? It's a bit hard to see the actual changes. Maybe it'd be easier to check out a new branch from dev and start again? Sorry!

@mrustl
Copy link
Contributor Author

mrustl commented Nov 30, 2018

Sorry that I didn't get it that the changes I made were already in the dev branch. As you pointed out that 'GITHUB_TOKEN' can be used I not make any changes passing an additional 'auth_token' argument and close this pull request.

@mrustl mrustl closed this Nov 30, 2018
@maelle
Copy link
Member

maelle commented Nov 30, 2018

Ok! Sorry, will update the contributing guidelines, it was bad practice on my part.

You can still open a new PR to pass the argument if you wish. :-)

Thanks again, and thanks for reporting your use case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants