Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing link of mock_components to hardware_interface #1992

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Add missing link of mock_components to hardware_interface #1992

merged 2 commits into from
Jan 10, 2025

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jan 10, 2025 •
edited
Loading

mock_components uses symbols defined in hardware_interface, but is not linking it. This is fine on ELF platforms where linker typically do not report errors is a symbols is undefined in a library, and the only important thing is that the symbols is eventually defined in the final linked executables, but on different platforms (like macOS or Windows) this missing link can create link errors.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@traversaro traversaro mentioned this pull request Jan 10, 2025
Open
saikishor
saikishor approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christophfroehlich
christophfroehlich approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Jan 10, 2025
@christophfroehlich christophfroehlich merged commit d501f1b into ros-controls:master Jan 10, 2025
24 checks passed
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
@traversaro @mergify
Add missing link of mock_components to hardware_interface (#1992)
fbbe471 
(cherry picked from commit d501f1b)

# Conflicts:
#	hardware_interface/CMakeLists.txt
@mergify mergify bot mentioned this pull request Jan 10, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@bmagyar bmagyar Awaiting requested review from bmagyar

@mamueluth mamueluth Awaiting requested review from mamueluth

@Maverobot Maverobot Awaiting requested review from Maverobot

@moriarty moriarty Awaiting requested review from moriarty

@qiayuanl qiayuanl Awaiting requested review from qiayuanl

@rosterloh rosterloh Awaiting requested review from rosterloh

Assignees
No one assigned
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@traversaro @christophfroehlich @saikishor