Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed version of incomplete 1st noetic reslease (4.0.0) #43

Merged
merged 12 commits into from
Aug 2, 2022

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented Jul 31, 2022

  • use catkin_install_python to uses /usr/bin/env python3 shebang for Noetic
  • revert 2to3 -w -f improt, which beraks on noetic
  • publish smach viewer image #37 does not work on noetic?

k-okada added 5 commits July 31, 2022 15:35
…because we want to use local xdot for Pytohn2 and sytem xdot for Python3
…or noetic, but need to remove smach_viewer/lib/smach_viewer from sys.path
@k-okada k-okada mentioned this pull request Jul 31, 2022
Signed-off-by: Mikael Arguedas <[email protected]>
@mikaelarguedas
Copy link
Contributor

Great! It works with these changes.

I opened #44 to fix some deprecation warnings, but we would need to check if this as no detrimental effect on older dependency versions (melodic)

I have a lot of errors still in some case (when updating the structure of some SMs or if I run smach_viewer after my SMs started) but I have the same issue with #39 so this PR makes it as working as #39 👍

Signed-off-by: Mikael Arguedas <[email protected]>
@k-okada k-okada changed the title Fix version 1st noetic reslease (4.0.0) Fixed version of incomplete 1st noetic reslease (4.0.0) Aug 1, 2022
Copy link
Contributor

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍

@k-okada k-okada merged commit 64e15cc into melodic-devel Aug 2, 2022
@k-okada k-okada deleted the fix_noetic branch August 2, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants