PlantFlagTool::makeFlag(): reload mesh resource #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Reset also resets the ResourceManager, such that the mesh resource is not available anymore and createEntity() will fail. Fixes ros-visualization/rviz#1618
|
|
|
I see. Sorry, I missed this commit when skimming through the list. Please remember then to forward-port this PR after merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Reset also resets the ResourceManager, such that the mesh resource
is not available anymore and createEntity() will fail.
Fixes ros-visualization/rviz#1618
@mabelzhang: Is there a particular reason that you branched off noetic-devel? I don't see any commits since then, which are noetic-only. In the past we use the same branch (kinetic-devel) for kinetic and melodic.
In any case this fix should be forward-ported to the noetic-devel branch as well.