Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rosmon: 2.3.2-1 in 'noetic/distribution.yaml' [bloom] #25205

Merged
merged 1 commit into from
May 29, 2020

Conversation

xqms
Copy link
Contributor

@xqms xqms commented May 29, 2020

Increasing version of package(s) in repository rosmon to 2.3.2-1:

rosmon

  • No changes

rosmon_core

* rosmon_core: cmake: increase minimum version to address policy warnings
* rosmon_core: *really* fix search for boost_python for python 3
* Contributors: Max Schwarz

rosmon_msgs

  • No changes

rqt_rosmon

  • No changes

@xqms xqms requested a review from sloretz as a code owner May 29, 2020 20:25
@sloretz
Copy link
Contributor

sloretz commented May 29, 2020

  • rosmon_core: really fix search for boost_python for python 3

@xqms you might be interested how ros-perception/vision_opencv#330 and ros-perception/vision_opencv#333 handled finding boost python for Ubuntu Focal and Debian Buster.

@sloretz sloretz merged commit 801f710 into ros:master May 29, 2020
@xqms
Copy link
Contributor Author

xqms commented May 29, 2020

Thanks, I was feeling a bit lost getting this to work ;)
I think I have found a passable solution using PYTHON_VERSION_MAJOR and PYTHON_VERSION_MINOR which is the python version used by catkin - just didn't activate it correctly in the last patch release. I'll take a look at your solution in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants