Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platformio #44119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add platformio #44119

wants to merge 1 commit into from

Conversation

Tacha-S
Copy link
Contributor

@Tacha-S Tacha-S commented Jan 8, 2025

Please add the following dependency to the rosdep database.

Package name:

platformio

Package Upstream Source:

https://github.com/platformio/platformio-core

Purpose of using this:

I use this to write the latest program to the microcontroller board during the build process.

Distro packaging links:

Links to Distribution Packages

@Tacha-S Tacha-S requested a review from a team as a code owner January 8, 2025 02:27
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Jan 8, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@christophebedard
Copy link
Member

Is the package available on Debian? We require at least Ubuntu and Debian: https://github.com/ros/rosdistro/blob/master/REVIEW_GUIDELINES.md#types-of-pull-requests

@christophebedard christophebedard added the more information needed Maintainers have asked for additional information label Jan 10, 2025
@Tacha-S
Copy link
Contributor Author

Tacha-S commented Jan 10, 2025

As indicated by the packages.debian.org/search?keywords=platformio&searchon=names&suite=all&section=all in the Debian section, this package does not exist in Debian.
However, it can be installed on Debian using pip.
In such cases, should it be written in python.yaml instead?

@christophebedard
Copy link
Member

Yes, you can add it as python3-platformio-pip in rosdep/python.yaml, but note that ROS packages that depend on pip keys cannot be released into a ROS distribution. It will only be useful for packages that get built from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more information needed Maintainers have asked for additional information rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants