support smart-leds-trait 0.2 and 0.3 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested it with both versions of the trait to confirm it works? |
|
I had not... Looks like it works with either version. Do you want the example included in this repo? chinoto@8e73f82 |
|
Do you need something else? |
9names
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
Don't need anything else, thanks for linking to an example - made it quick to test.
Please make a PR for your example code once this is merged. I personally always want examples for lib crates but we'll let everyone else weigh in too.
Thanks for your patience, it's a busy time of year.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30 and #34 have been in limbo due to incompatibility with 0.2. @jannic wrote code to add compatibility to #30, but the author of #30 hasn't accepted it yet. As odd as it is, I hope it is acceptable to submit their work for them.