Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ssh-agent id selection to the UI #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

move ssh-agent id selection to the UI #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mosh_app/mosh_client.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@
</select>
</td>
</tr>
<tr id="ssh-agent-id-row">
<td>SSH agent id:</td>
<td><input id="ssh-agent-id" type="text" placeholder="beknehfpfkghjoafdifaflglpjkojoco"></td>
</tr>
<tr>
<td>
DNS settings:
Expand Down
2 changes: 2 additions & 0 deletions mosh_app/mosh_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,8 @@ function onConnectClick(e) {
break;
}
}
args['ssh-agent-id'] = form['ssh-agent-id'].value ||
form['ssh-agent-id'].placeholder;

// Define an ID that should, usually, uniquely define a connection to a
// server. This will preserve the window position across sessions. But still
Expand Down
3 changes: 1 addition & 2 deletions mosh_app/mosh_window.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ mosh.CommandInstance = function(argv) {
this.agentPort_ = null;

// App ID of an SSH agent.
// TODO: Make this a user setting.
this.agentAppID_ = 'beknehfpfkghjoafdifaflglpjkojoco';
this.agentAppID_ = argv.args['ssh-agent-id'];
};

mosh.CommandInstance.prototype.run = function() {
Expand Down