-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: replace Stamen/Stadia in vignettes, function documentation, and inst
examples
#913
Fix: replace Stamen/Stadia in vignettes, function documentation, and inst
examples
#913
Conversation
Thank you! |
@schloerke ICYMI I replied in the issue: #912 (comment). I'm in favor of cutting down on our usage of Stadia maps but we should keep at least one or two examples and we should go through the stated process of setting up domain-based auth so we can have experience with the process and also monitor how it works. |
@gadenbuie Totally did. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jack-davison! I added one of the Stamen examples back (under "Third-party tiles") along with some instructions on migrating to Stadia.
I also registered an account and added our rstudio.github.io
domain to the allowlist, so the Stamen tiles should work as expected in our docs.
This fixes #912 and a bit more.
I've replaced all "Stadia" (formerly "Stamen") tiles in the vignettes with tile providers which should display on the
{pkgdown}
website. Can see the present issue at: https://rstudio.github.io/leaflet/articles/basemaps.html#combining-tile-layersI've also gone through and replaced all of the "Stamen" examples in the function docs with alternates. These would not work after the Stamen/Stadia situation described in Stamen Tile Deprecation Warning #883 anyway, so need fixing regardless of the above point!
These fixes only change the providers in examples, and anything directly associated with them (e.g., if the
group
was "Stamen" before it's now "Carto", and in one instance the colour of circles was changed to stand out better on a new basemap).Re-ran
devtools::document()
.