Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(planMigrate): Bad files are send when IgnoreUnknown is set #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mama59
Copy link

@Mama59 Mama59 commented Mar 3, 2022

No get exising file on other folder if IgnoreUnknown is true

@rubenv
Copy link
Owner

rubenv commented Aug 12, 2022

@Mama59 Could you add a unit test that demonstrates what goes wrong here and what it fixes?

@Mama59
Copy link
Author

Mama59 commented Aug 16, 2022

@Mama59 Could you add a unit test that demonstrates what goes wrong here and what it fixes?

@rubenv
Test added, result without the change

----------------------------------------------------------------------
FAIL: migrate_test.go:669: SqliteMigrateSuite.TestMigrateWith2Folders

migrate_test.go:685:
    c.Assert(len(migrationsOtherPlanned), Equals, 1)
... obtained int = 0
... expected int = 1

OOPS: 35 passed, 1 FAILED
--- FAIL: Test (0.03s)
FAIL
exit status 1
FAIL	github.com/rubenv/sql-migrate	0.742s

Result with the change

OK: 36 passed
PASS
ok  	github.com/rubenv/sql-migrate	0.861s

@Mama59 Mama59 force-pushed the master branch 3 times, most recently from 42f6d36 to 415fc3e Compare August 25, 2022 14:05
No get exising file on other folder if IgnoreUnknown is true

Signed-off-by: Marine Bal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants