Fixes for running with Cuprite on v0.15

rubycdp · Jan 4, 2025 · a452215 · a452215
1 parent 14666ca
commit a452215
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/ferrum/page/screencast.rb b/lib/ferrum/page/screencast.rb
@@ -7,8 +7,8 @@ class Page
     module Screencast
       attr_reader :screencaster
 
-      def start_screencast
-        @screencaster.start_screencast
+      def start_screencast(...)
+        @screencaster.start_screencast(...)
       end
 
       def stop_screencast

diff --git a/lib/ferrum/screencaster.rb b/lib/ferrum/screencaster.rb
@@ -27,8 +27,8 @@ def add_frame(params)
     def recordings_dir
       return @recordings_dir if defined? @recordings_dir
 
-      session_id = @page.client.session_id
-      @recordings_dir = FileUtils.mkdir_p("#{@base_dir}/screencast_recordings/#{session_id}/").first
+      timestamp = (Time.now.to_f * 1000).to_i
+      @recordings_dir = FileUtils.mkdir_p("#{@base_dir}/screencast_recordings/#{timestamp}/").first
       @recordings_dir
     end