Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Don't pass browser instance everywhere #431

Merged
merged 7 commits into from
Jan 3, 2024
Merged

refactor: Don't pass browser instance everywhere #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
352e142
refactor: don't pass browser instance everywhere
route Jan 3, 2024
927281f
fix: Errno::ENOENT on browser start
route Jan 3, 2024
1884bb1
chore: Add CHANGELOG entry
route Jan 3, 2024
3987a93
ref: Browser::Options
route Jan 3, 2024
e9892fe
chore: update pdf-reader
route Jan 3, 2024
68bc00f
chore: show progress
route Jan 3, 2024
49c18ee
chore: update sinatra
route Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .rspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
--color
--format=doc
--format=progress
--require spec_helper
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
- `Ferrum::Page#screeshot` accepts :area option [#410]
- Resizing page on creation is gone and moved to Cuprite [#427]
- Min Ruby version is 2.7
- Refactored internal API of `Browser`, `Page`, `Context`, `Contexts`, `Target` instead of passing browser and making
cyclic dependency on the browser instance, we pass now a simple client [#431]

### Fixed

Expand Down
4 changes: 2 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ gem "byebug", "~> 11.0", platforms: %i[mri mingw x64_mingw]
gem "chunky_png", "~> 1.3"
gem "image_size", "~> 2.0"
gem "kramdown", "~> 2.0", require: false
gem "pdf-reader", "~> 2.2"
gem "pdf-reader", "~> 2.12"
gem "puma", ">= 5.6.7"
gem "rake", "~> 13.0"
gem "redcarpet", require: false, platform: :mri
gem "rspec", "~> 3.8"
gem "rubocop", "~> 1.22"
gem "rubocop-rake", require: false
gem "sinatra", "~> 2.0"
gem "sinatra", "~> 3.2"
gem "yard", "~> 0.9", require: false

gemspec
Loading