Fix: docker databases #1346
Open
Fix: docker databases #1346
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmilljr24
commented
Jan 25, 2025
| @@ -50,6 +50,8 @@ services: | |||
| environment: | |||
| DATABASE_URL: postgres://${DATABASE_USERNAME:-postgres}:${DATABASE_PASSWORD:-password}@postgres:5432/petrescue_development | |||
| RAILS_ENV: development | |||
| SERVICE_NAME: app | |||
| SOLID_QUEUE_IN_PUMA: true | |||
There was a problem hiding this comment.
When true, runs solid queue job service via puma.
jmilljr24
commented
Jan 25, 2025
| @@ -4,5 +4,10 @@ set -e | |||
| # Remove a potentially pre-existing server.pid for Rails. | |||
| rm -f /petrescue/tmp/pids/server.pid | |||
|
|
|||
| if [ "$SERVICE_NAME" = "app" ]; then | |||
There was a problem hiding this comment.
We only want this to run on the app service not sass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
Resolves #1334
✍️ Description
The queue and cable database's tables were not being created when initially running db:migrate. The default install of Solid Cable and Solid queue do not add a migration file. The tables are built from the schema files. Running db:migrate seems to looks for the migration files and when there is none, it overwrites the schema files and we end up with an database with no tables.
This change adds db:prepare to the entry point file which properly creates the tables and also seeds the db. I also removed asset precompile, maybe that will help with the assets issues in development?? #1317
I'd suggest nuking your database, then run docker compose build.
📷 Screenshots/Demos