-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for daemons #346
Docs for daemons #346
Conversation
300d24b
to
910beb0
Compare
827df06
to
2810abd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes applied
@voetberg addressed your suggestions. |
af9c7ff
to
6decc10
Compare
seems to be related to this PR that just got merged rucio/rucio#7012 |
we need to add rich here: https://github.com/rucio/documentation/blob/main/tools/requirements.txt - i'm making a PR now |
You're way ahead of me, I was just putting one in myself lol |
PR to add dependency: #407 This is happening right after it pulls the cached test image:
which was last published 12 hours ago: https://github.com/rucio/rucio/pkgs/container/rucio%2Frucio-autotest I just started a new cache build run: https://github.com/rucio/rucio/actions/runs/12142963668, should take 20 mins. After it's built, I'd say:
|
@rdimaio build failed, trying adding rich now. |
The problem isn't from docs, it's from the main repo. This commit - rucio/rucio@d58adca |
the error is different now that |
@rdimaio all good now thanks! |
@rdimaio I thought it was green as the "Merge" button appeared but the build is still failing. |
CI looks good here https://github.com/rucio/documentation/actions/runs/12176030045 |
The CI was running off your branch and not the main repo, so the failed doc building was still present. The fixes in main solve the build problem when it merges, but not in the PR itself. |
@voetberg what else is missing for these changes appear in the main documentation portal? |
@labkode They're present? https://rucio.cern.ch/documentation/started/daemons If you mean the sidebar, it looks like your pr was missing adding them to |
just realized that these daemons are under the edit: my bad, that's the "Getting started" docs directory, so I think it fits (could argue it might go into the Operator docs instead but I think it's fine in the current section) |
Fixes #296