Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Add a Lilac dataset reader. #563

Merged
merged 15 commits into from
Oct 31, 2023
Merged

Add a Lilac dataset reader. #563

merged 15 commits into from
Oct 31, 2023

Conversation

nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Oct 5, 2023

Description

Adds a Lilac reader .

Lilac is an open-source product that helps you analyze, enrich, and clean unstructured data with AI.

It can be used to analyze, clean, structure, and label data that can be used in downstream LlamaIndex and LangChain applications.

Type of Change

Please delete options that are not relevant.

  • New Loader/Tool

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I stared at the code and made sure it makes sense

I also just tested from python:

IMG_1917

Suggested Checklist:

  • I have added a library.json file if a new loader/tool was added
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Copy link
Collaborator

@EmanuelCampos EmanuelCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a few comments

can you make sure to run make format; make lint?

thanks for the contribution

llama_hub/lilac_reader/base.py Outdated Show resolved Hide resolved
poetry.lock Outdated Show resolved Hide resolved
@nsthorat
Copy link
Contributor Author

nsthorat commented Oct 7, 2023

Thanks @EmanuelCampos, all are done :)

Copy link
Collaborator

@EmanuelCampos EmanuelCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! did two comments, small things :)

llama_hub/lilac_reader/base.py Outdated Show resolved Hide resolved
llama_hub/lilac_reader/base.py Outdated Show resolved Hide resolved
@EmanuelCampos
Copy link
Collaborator

bump @nsthorat

@EmanuelCampos
Copy link
Collaborator

quick bump @nsthorat

if you can make the PR editable by maintainer I can finish it

@nsthorat
Copy link
Contributor Author

Ah, so sorry for dropping this. I made the changes :)

Copy link
Collaborator

@EmanuelCampos EmanuelCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just a nit then we're good to merge

llama_hub/lilac_reader/__init__.py Show resolved Hide resolved
@EmanuelCampos
Copy link
Collaborator

EmanuelCampos commented Oct 31, 2023

@nsthorat the linting broken, we're almost there haha

can you run make format; make lint

@nsthorat
Copy link
Contributor Author

haha, done :)

@EmanuelCampos EmanuelCampos merged commit b4a844f into run-llama:main Oct 31, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants