-
Notifications
You must be signed in to change notification settings - Fork 736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a few comments
can you make sure to run make format; make lint
?
thanks for the contribution
Thanks @EmanuelCampos, all are done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! did two comments, small things :)
bump @nsthorat |
quick bump @nsthorat if you can make the PR editable by maintainer I can finish it |
Ah, so sorry for dropping this. I made the changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, just a nit then we're good to merge
@nsthorat the linting broken, we're almost there haha can you run |
haha, done :) |
Description
Adds a Lilac reader .
Lilac is an open-source product that helps you analyze, enrich, and clean unstructured data with AI.
It can be used to analyze, clean, structure, and label data that can be used in downstream LlamaIndex and LangChain applications.
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
I also just tested from python:
Suggested Checklist:
make format; make lint
to appease the lint gods