Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Update TrafilaturaWebReader in library.json #602

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

ravi03071991
Copy link
Contributor

@ravi03071991 ravi03071991 commented Oct 25, 2023

Description

TrafilaturaWebReader was absent from the library.json file and its installation check was missing. Someone on Discord reported an issue due to this. This PR addresses and resolves the problem.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix / Smaller change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have added a library.json file if a new loader/tool was added
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

llama_hub/library.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@EmanuelCampos EmanuelCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aweeesome, thank you

@EmanuelCampos EmanuelCampos merged commit a5d2643 into run-llama:main Oct 25, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants