Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

fix(PyMuPDF): store the str path instead of the Path object #917

Merged
merged 1 commit into from
Feb 3, 2024
Merged

fix(PyMuPDF): store the str path instead of the Path object #917

merged 1 commit into from
Feb 3, 2024

Conversation

boarush
Copy link
Contributor

@boarush boarush commented Feb 1, 2024

Description

Store the path in str when using the PyMuPDF Loader in case a Path object is passed.

Type of Change

  • Bug fix / Smaller change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have added a library.json file if a new loader/tool was added
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@boarush boarush changed the title fix: store the str path instead of the Path object fix(PyMuPDF): store the str path instead of the Path object Feb 1, 2024
@anoopshrma anoopshrma merged commit 965a254 into run-llama:main Feb 3, 2024
3 checks passed
@boarush boarush deleted the fix/pymupdf-file-path branch February 8, 2024 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants