Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a nlp section section #1932

Merged
merged 11 commits into from
Oct 14, 2023
Merged

added a nlp section section #1932

merged 11 commits into from
Oct 14, 2023

Conversation

Arnabhit
Copy link
Contributor

@Arnabhit Arnabhit commented Oct 10, 2023 •
edited by rupali-codes
Loading

Fixes Issue
Closes #1919

Changes proposed

I Have added a subcategory Natural Language Processing under the category AI.

Screenshots

Screenshot (63)

Screenshot (62)

@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2023 5:55pm

github-actions[bot]
github-actions bot reviewed Oct 10, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Arnabhit, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

CBID2
CBID2 requested changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions @Arnabhit

database/artificial_intelligence/natural-language-processing.json Outdated Show resolved Hide resolved
Anmol-Baranwal
Anmol-Baranwal requested changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shorten the subcategory name to nlp, people who know will understand it.

image

Also, there should be no - between the name which happened due to this

image

@Arnabhit
Copy link
Contributor Author

ok i will do it

@Anmol-Baranwal
Copy link
Collaborator

@Arnabhit
Please take your time, no need to rush. We will review whenever you have made the changes.

@Arnabhit
Copy link
Contributor Author

ok thank you

@Arnabhit
Copy link
Contributor Author

done

CBID2
CBID2 requested changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Arnabhit! :) I pointed out a proofreading error in my inline comment. In the future, consider running your descriptions through Grammarly or Spellcheck before making a pull request. Other than that, you're off to a great start! :)

@rupali-codes rupali-codes added goal: new-link Addition of new links related contributions goal: new-category Addition of new categories related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) chore Might take time to finish labels Oct 12, 2023
@Arnabhit
Copy link
Contributor Author

done 🥲🥲

Anmol-Baranwal
Anmol-Baranwal reviewed Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rupali-codes
Can you check why we can't access the description of it?

image

Other than that, everything seems fine.

@Arnabhit
Copy link
Contributor Author

I am also not able to click the description icon. I am not able to do it. Can you plz help

@Anmol-Baranwal
Copy link
Collaborator

@Arnabhit
Just add a description in TopBar/CategoryDescriptions.ts. We will resolve the bug internally.

@Arnabhit
Copy link
Contributor Author

added the description

CBID2
CBID2 previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good description-wise

Anmol-Baranwal
Anmol-Baranwal previously approved these changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Anmol-Baranwal Anmol-Baranwal added the status: ready-to-merge Approved & its ready-to-merge label Oct 14, 2023
@rupali-codes rupali-codes dismissed stale reviews from Anmol-Baranwal and CBID2 via 3726909 October 14, 2023 17:55
@rupali-codes
Copy link
Owner

@rupali-codes Can you check why we can't access the description of it?

image

Other than that, everything seems fine.

it was the name, it should be as per the URL but without dash or anything

rupali-codes
rupali-codes approved these changes Oct 14, 2023
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rupali-codes rupali-codes merged commit 3f78d36 into rupali-codes:main Oct 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@rupali-codes rupali-codes rupali-codes approved these changes

@CBID2 CBID2 CBID2 left review comments

@Anmol-Baranwal Anmol-Baranwal Anmol-Baranwal left review comments

Assignees

@Arnabhit Arnabhit

Labels
chore Might take time to finish goal: new-category Addition of new categories related contributions goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADD] <AI/Natural Language Processing>
4 participants
@Arnabhit @Anmol-Baranwal @rupali-codes @CBID2