Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Neetcode in Competitive Programming category #1966

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

singodiyashubham87
Copy link
Contributor

Fixes Issue

Fixes #1918

Changes proposed

I have added the Neetcode youtube channel into the database of the Competitive Programming category and validated the JSON too.

Screenshots

image

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 5:36am

@github-actions github-actions bot added chore Might take time to finish goal: new-category Addition of new categories related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) labels Oct 12, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, singodiyashubham87, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singodiyashubham87 please don't remove any existing resource, kindly add Tushar Roy back

@singodiyashubham87
Copy link
Contributor Author

@rupali-codes I'm really sorry for the mistake, I have rectified my mistake, kindly check it once.

Anmol-Baranwal
Anmol-Baranwal previously approved these changes Oct 13, 2023
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Anmol-Baranwal
Copy link
Collaborator

@CBID2
Please review.

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @singodiyashubham87. I just gave some tips on how you can improve your entry.

database/competitive_programming/cp-tutorials.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

@CBID2 CBID2 requested a review from rupali-codes October 16, 2023 13:13
@CBID2 CBID2 added status: ready-to-merge Approved & its ready-to-merge hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest labels Oct 16, 2023
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rupali-codes rupali-codes merged commit 522da26 into rupali-codes:main Oct 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Might take time to finish goal: new-category Addition of new categories related contributions hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: low Addition of new links/categories or doing any small task (e.g fixing typos) status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] Neetcode in Competitive Programming Category
4 participants