Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Jenkins documentation to Devops #1972

Closed
wants to merge 4 commits into from
Closed

chore: add Jenkins documentation to Devops #1972

wants to merge 4 commits into from

Conversation

goobric
Copy link
Contributor

@goobric goobric commented Oct 12, 2023

Closes #1931

Fixes Issue

Closes #1931

Changes proposed

Added Jenkins documentation to the Devops category

Screenshots

Note to reviewers

231012_linkhub_jenkins1
231012_linkhub_jenkins2
231012_linkhub_jenkins3

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 7:51am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, goobric, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @goobric. Just needs improvement

database/devops/jenkins.json Outdated Show resolved Hide resolved
@Anmol-Baranwal Anmol-Baranwal changed the title Closes #1931 Added Jenkins documentation to Devops chore: add Jenkins documentation to Devops Oct 13, 2023
Co-authored-by: Christine Belzie <[email protected]>
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goobric
You need to add it here: database\data.ts

image

As you can see it's not visible.

image

@goobric goobric closed this by deleting the head repository Oct 13, 2023
@Anmol-Baranwal
Copy link
Collaborator

@goobric
Why did you delete the head repo?

@goobric
Copy link
Contributor Author

goobric commented Oct 14, 2023

hi @Anmol-Baranwal
I responded to this message yesterday at about 14:10 UTC, using the github app on my mobile/cell phone; yet my response isn't listed!
I updated the data.ts file with the 'jenkins' information:

  • saved the file locally on my cloned repo
  • added the file
  • committed the file
  • pushed the file
    received an error message about 'fast-forward' use 'pull' command from forked repo
    tried to 'pull' my forked repo; received another error!
    So I thought, "maybe it's better to start again" (clearly this was the wrong approach); so I deleted my locally cloned repo; deleted the forked repo from my github account.
  • I forked the original repo to my gh account;
  • cloned the repo to my local computer
  • created a new branch
  • added details about 'jenkins' to index, data.ts, CategoryDescription.ts, added jenkins.json in the devops directory
  • saved the files locally
  • added the files to the stage
  • commited the files
  • pushed the files to my forked repo
    Everything pushed successfully to my forked repo
  • yet, on my repo; there was no option to "Compare & PR" !
    What did I do wrong? please explain to me what I should have done, to have a successful PR?

@goobric
Copy link
Contributor Author

goobric commented Oct 14, 2023

@Anmol-Baranwal what do I do now?
Do I start the process again from the beginning? I am confused!

@Anmol-Baranwal
Copy link
Collaborator

@goobric Comment on this PR: #1976

@Anmol-Baranwal
Copy link
Collaborator

I mistakenly created a PR, so the PR will be merged as a co-authored commit.

If you want to only do it urself, then you can create a fresh PR.

For now: it will be similar to this, we both will be assigned to the PR.

image

@goobric
Copy link
Contributor Author

goobric commented Oct 14, 2023

@Anmol-Baranwal that's great :-)
thanks for co-authoring, I have never co-authored a PR before!
This should be a common option on github (probably is already) I would like to co-author on more PRs; but I don't know how.
I am a big advocate of pair-programming and problem solving.
Thanks for creating the PR and merging it.
Have a wonderful weekend.

@Anmol-Baranwal
Copy link
Collaborator

It hasn't been merged, you need to comment there in order for me to assign the PR to you.

Then we can go forward.

@goobric
Copy link
Contributor Author

goobric commented Oct 14, 2023

@Anmol-Baranwal
I am so sorry to ask such a stupid question, but what do I need to say in the comment for the PR to be assigned?
Do I just say, "Please assign this PR me"

231014_LinksHub_PR1
231014_LinksHub_PR2
231014_LinksHub_PR3

@Anmol-Baranwal
Copy link
Collaborator

Anmol-Baranwal commented Oct 14, 2023

@goobric
Comment anything. GitHub works in a way, that those who have raised or commented can be assigned.

So, it is not showing your option for assignee.

As you can see, your name is not available for assignee.

image

@Anmol-Baranwal
Copy link
Collaborator

See once someone comments.

image

His name is available.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] Want to add Jenkins documentation.
3 participants