Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Accessibility Improvements to Links #1989

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Add Accessibility Improvements to Links #1989

merged 1 commit into from
Oct 21, 2023

Conversation

supunsathsara
Copy link
Contributor

Fixes Issue

Closes #1978

Changes proposed

  • Changed aria-label attributes of category links for better screen reader accessibility.
  • Added aria-label attributes of subcategory links for better screen reader accessibility.

Screenshots

Note to reviewers

@vercel
Copy link

vercel bot commented Oct 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 4:58am

@github-actions github-actions bot added accessibility Code is not up to WCAG standards chore Might take time to finish goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) priority: medium Modifying an existing feature labels Oct 15, 2023
github-actions[bot]
github-actions bot reviewed Oct 15, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, supunsathsara, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

CBID2
CBID2 approved these changes Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @supunsathsara! :) @Anmol-Baranwal, @rupali-codes, you're up! :)

@CBID2 CBID2 added hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: medium Modifying an existing feature and removed goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) priority: medium Modifying an existing feature labels Oct 15, 2023
Anmol-Baranwal
Anmol-Baranwal requested changes Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this as well.

image

It is from your deployed link

@supunsathsara
Copy link
Contributor Author

Fix this as well.

image

It is from your deployed link

I believe the issue here lies in the fact that, even though it has a clear aria-label, automated test results might interpret "Open Source Community" as referring to the entire open-source community, rather than just contributors in LinksHub. Changing it to a more specific term could resolve this, but I opted not to alter the website's content.

If it is acceptable to make this change, I am open to doing so. Additionally, if you can think of any other reasons why this issue might occur, please feel free to suggest. Appreciate your understanding.

@Anmol-Baranwal
Copy link
Collaborator

Anmol-Baranwal commented Oct 15, 2023 •
edited
Loading

I will check it, and let you know. The reason you mentioned is correct.

@CBID2 CBID2 requested a review from Anmol-Baranwal October 21, 2023 07:26
@CBID2 CBID2 added the status: ready-to-merge Approved & its ready-to-merge label Oct 21, 2023
@CBID2
Copy link
Collaborator

CBID2 commented Oct 21, 2023

@Anmol-Baranwal and @rupali-codes, can you review this please?

@rupali-codes rupali-codes merged commit 5bd77cc into rupali-codes:main Oct 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@CBID2 CBID2 CBID2 approved these changes

@rupali-codes rupali-codes rupali-codes approved these changes

@Anmol-Baranwal Anmol-Baranwal Awaiting requested review from Anmol-Baranwal Anmol-Baranwal is a code owner

Assignees

@supunsathsara supunsathsara

Labels
accessibility Code is not up to WCAG standards chore Might take time to finish hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: medium Modifying an existing feature status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Enhanced Accessibility Features for Improved User Experience
4 participants
@supunsathsara @Anmol-Baranwal @CBID2 @rupali-codes