Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added NASA's API in api.json #2045

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Added NASA's API in api.json #2045

merged 1 commit into from
Oct 22, 2023

Conversation

SoulNikhar
Copy link
Contributor

@SoulNikhar SoulNikhar commented Oct 20, 2023 •
edited by CBID2
Loading

Fixes Issue

Closes #2048

Changes proposed

This PR adds NASA's API to the API.json file.

Note to reviewers

@SoulNikhar
Update api.json
6cae0b1 
NASA's API offers a comprehensive repository of space-related data, images, and mission information, facilitating exploration and research.
github-actions[bot]
github-actions bot reviewed Oct 20, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, SoulNikhar, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 10:09am

This was referenced Oct 20, 2023
Closed
Closed
@Anmol-Baranwal
Copy link
Collaborator

@SoulNikhar
We are neglecting this now, but in the future, you need to create an issue and allow us to assign you the issue before you start working and submit a PR. Not following this process will require us to close your pull request.

This is outlined in the contributing guidelines.
image

You need to follow a predefined flow in order to contribute to Open Source. You may be new, so it is important to understand this. Most of the maintainers will mark it as spam and close it. I'm converting this into a draft for now.

Create an issue and tag me.

@Anmol-Baranwal Anmol-Baranwal marked this pull request as draft October 20, 2023 12:24
@SoulNikhar
Copy link
Contributor Author

@Anmol-Baranwal Thanks bro for not mark it as spam.

@SoulNikhar
Copy link
Contributor Author

@Anmol-Baranwal , I created an issue as per what you told me

@rupali-codes
Copy link
Owner

rupali-codes commented Oct 21, 2023 •
edited
Loading

@Anmol-Baranwal , I created an issue as per what you told me

Thanks, now reference the issue in this PR by editing the description add closes #your_issue_number

@SoulNikhar
Copy link
Contributor Author

@Anmol-Baranwal , I created an issue as per what you told me

Thanks, now reference the issue in this PR by editing the description add closes #your_issue_number

closes #2048

@SoulNikhar
Copy link
Contributor Author

@rupali-codes and @Anmol-Baranwal I have answered all the Questions in the Issue section #2048

@Rohxn16 Rohxn16 mentioned this pull request Oct 21, 2023
Closed
@CBID2 CBID2 marked this pull request as ready for review October 21, 2023 19:57
@CBID2 CBID2 added goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest labels Oct 21, 2023
CBID2
CBID2 approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SoulNikhar! :) There was some missing information in your PR's form, so I made the necessary changes. In the future, follow the comments in the PR template(e.g., they look like this <! -- text --> to help you fill it out effectively. Other than that, you did good! :) @Anmol-Baranwal and @rupali-codes, it's your turn to review this PR.

Anmol-Baranwal
Anmol-Baranwal approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Anmol-Baranwal Anmol-Baranwal added the status: ready-to-merge Approved & its ready-to-merge label Oct 21, 2023
rupali-codes
rupali-codes approved these changes Oct 22, 2023
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rupali-codes rupali-codes merged commit fbf42d4 into rupali-codes:main Oct 22, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@CBID2 CBID2 CBID2 approved these changes

@rupali-codes rupali-codes rupali-codes approved these changes

@Anmol-Baranwal Anmol-Baranwal Anmol-Baranwal approved these changes

Assignees

@SoulNikhar SoulNikhar

Labels
goal: new-link Addition of new links related contributions hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: low Addition of new links/categories or doing any small task (e.g fixing typos) status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NASA's API in api.json
4 participants
@SoulNikhar @Anmol-Baranwal @rupali-codes @CBID2