Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:Add new link to c++(#2040) #2049

Merged

Conversation

ankush-w17
Copy link
Contributor

@ankush-w17 ankush-w17 commented Oct 20, 2023

Fixes Issue

Closes #2040

Changes proposed

Added new c++ course to the category : language sub-category : c++

Screenshots

Screenshot 2023-10-20 181905

Note to reviewers

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 0:22am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, ankush-w17, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@github-actions github-actions bot added chore Might take time to finish goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) labels Oct 20, 2023
@rupali-codes rupali-codes added hacktoberfest hacktoberfest2023 hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest labels Oct 21, 2023
Co-authored-by: Rupali Haldiya <[email protected]>
Anmol-Baranwal
Anmol-Baranwal previously approved these changes Oct 21, 2023
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

database/languages/cpp.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ankush-w17! :) I pointed out some [typos or proofreading errors] that could be improved. Other than that, you’re off to a great start! :)

Co-authored-by: Christine Belzie <[email protected]>
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :) @Anmol-Baranwal, please review this again.

@CBID2 CBID2 requested a review from Anmol-Baranwal October 23, 2023 19:15
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Anmol-Baranwal Anmol-Baranwal added the status: ready-to-merge Approved & its ready-to-merge label Oct 25, 2023
@ankush-w17
Copy link
Contributor Author

@rupali-codes, Please review this PR.

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rupali-codes rupali-codes merged commit 3675132 into rupali-codes:main Oct 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Might take time to finish goal: new-link Addition of new links related contributions hacktoberfest hacktoberfest2023 hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: low Addition of new links/categories or doing any small task (e.g fixing typos) status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] New link for C++ in Languages category
4 participants