Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer layout issue ⚒️✨ #2058

Merged
merged 9 commits into from
Oct 22, 2023
Merged

fix: footer layout issue ⚒️✨ #2058

merged 9 commits into from
Oct 22, 2023

Conversation

0xabdulkhaliq
Copy link
Contributor

Fixes Issue

Closes #2051

Changes proposed

  • Removed unwanted margin from Footer component
  • Optimized Back to Top button position for Mobile devices
  • Minor changes for other components too, because when updating Footer it affected other components too.

Screenshots

BEFORE - [ MOBILE ] AFTER - [ MOBILE ]
BEFORE - [ MOBILE ] AFTER - [ MOBILE ]
BEFORE - [ DESKTOP ] AFTER - [ DESKTOP ]
BEFORE - [ DESKTOP ] AFTER - [ DESKTOP ]

@vercel
Copy link

vercel bot commented Oct 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2023 10:31am

@github-actions github-actions bot added bug Something isn't working priority: medium Modifying an existing feature labels Oct 21, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, 0xabdulkhalid, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @rupali-codes and @Anmol-Baranwal, your turn! :)

@CBID2 CBID2 added the hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest label Oct 21, 2023
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice to me!

@Anmol-Baranwal Anmol-Baranwal added the status: ready-to-merge Approved & its ready-to-merge label Oct 22, 2023
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Anmol-Baranwal Anmol-Baranwal merged commit c6e024c into rupali-codes:main Oct 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: medium Modifying an existing feature status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: unwanted bottom margin for footer 🙅🏻 🚫
4 participants