Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Dockerfile for reduced layers #2062

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

Saurav-Pant
Copy link
Contributor

Fixes Issue

Closes #2028

Changes proposed

  1. This PR optimizes the Dockerfile to reduce the number of layers, which will make the Docker image smaller and faster to build. This was done by combining commands into single lines.
  2. Combine COPY commands into a single line to reduce the number of layers.

@vercel
Copy link

vercel bot commented Oct 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2023 1:35pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Saurav-Pant, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2
Copy link
Collaborator

CBID2 commented Oct 21, 2023

Hi @Saurav-Pant! :) Can you post a screenshot of your contribution in the PR form? I'm having trouble visualizing what your changes do.

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rupali-codes
Check it.

🚀 Looks good to me.

@CBID2
You can read the issue description. It improves dockerfile.

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Anmol-Baranwal Anmol-Baranwal added the status: ready-to-merge Approved & its ready-to-merge label Oct 22, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2 CBID2 added goal: refactor Refactoring the codebase priority: medium Modifying an existing feature hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest labels Oct 23, 2023
@CBID2 CBID2 merged commit 5b8282f into rupali-codes:main Oct 23, 2023
10 checks passed
@CBID2
Copy link
Collaborator

CBID2 commented Oct 23, 2023

Thanks @Saurav-Pant!:) It was wonderful working with you! 😄 If you want to stay updated on LinksHub, join our Discord community! :) We'd love to have you! :)

@Saurav-Pant Saurav-Pant deleted the Saurav branch October 23, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: refactor Refactoring the codebase hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: medium Modifying an existing feature status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Optimize Dockerfile for Efficient Image Building
4 participants