Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create php.json #2115

Closed
wants to merge 3 commits into from
Closed

Create php.json #2115

wants to merge 3 commits into from

Conversation

Alisha-786
Copy link

@Alisha-786 Alisha-786 commented Oct 25, 2023

Fixes Issue

resolves #2077

  • I have added a new file in JSON for the PHP language. It can be beneficial. It fixes the above-mentioned issue.

Note to reviewers

Please review my code and if there is any issue, Let me know :).

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ❌ Failed (Inspect) Oct 29, 2023 4:35pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Alisha-786, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Anmol-Baranwal
Copy link
Collaborator

@Alisha-786
Following the PR template is a must. It includes special words like 'fixes' or 'resolves' that connect your issue to the PR, as explained in the official docs.

If you don't link the issue correctly, even after the PR is merged, the issue might stay open, causing huge problems.

You can see here.
image

I'm doing it for you this time. Please ensure it next time.

Just a heads-up to help you link issue properly next time. Have a great day!

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alisha-786
The subcategory won't be created by just adding a php json. Follow the contributing guidelines.

@rupali-codes rupali-codes added goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest chore Might take time to finish labels Oct 27, 2023
@rupali-codes
Copy link
Owner

@Alisha-786 are you still working on this PR?

@Alisha-786
Copy link
Author

Alisha-786 commented Oct 29, 2023

@rupali-codes @Anmol-Baranwal
Sorry for the delay. I have made changes can you please check and if there is some problem then tell me.

@Anmol-Baranwal
Copy link
Collaborator

@Alisha-786
Is it deploying locally?

@rupali-codes rupali-codes removed the hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest label Nov 2, 2023
@Anmol-Baranwal
Copy link
Collaborator

@Alisha-786
I'm closing this issue due to inactivity. Please feel free to reopen it if you'd like to contribute or have further discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Might take time to finish goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] <write a small description here>
3 participants