Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a New Card in DevTools category #2528

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

joyfinder
Copy link
Contributor

Changes proposed

  • A new source of dev tools, HackMD, is added, and recommended. It is not only user-friendly in UI perspective, but also convenient for developers to organize notes etc.

Screenshots

Screenshot 2024-10-07 at 9 59 15 PM

Note to reviewers

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 10:40am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@github-actions github-actions bot added chore Might take time to finish goal: new-category Addition of new categories related contributions goal: new-feature New feature or request priority: high Making completely new feature priority: low Addition of new links/categories or doing any small task (e.g fixing typos) labels Oct 7, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

rupali-codes
rupali-codes previously approved these changes Oct 10, 2024
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rupali-codes
Copy link
Owner

@joyfinder please resolve the merge conflicts

@joyfinder
Copy link
Contributor Author

joyfinder commented Oct 10, 2024

@joyfinder please resolve the merge conflicts

Yes, already fixed it.

Thank you for letting me know.

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @joyfinder, you have removed the previous resource, you don't need to remove it, just keep of them

@joyfinder
Copy link
Contributor Author

hey @joyfinder, you have removed the previous resource, you don't need to remove it, just keep of them

So should I remove the previous commit instead?

And would you clarify what's the main issue of branch conflict if the added content is fine?

Thank you.

@rupali-codes
Copy link
Owner

hey @joyfinder, you have removed the previous resource, you don't need to remove it, just keep of them

So should I remove the previous commit instead?

And would you clarify what's the main issue of branch conflict if the added content is fine?

Thank you.

sure, the current commit will remove the previous resource (Uptime Kuma) this one

@joyfinder
Copy link
Contributor Author

@rupali-codes

Would you check it again whether it meets your requirement?

Besides, I also opened the issue, and please assign it to me.

Thank you.

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joyfinder still, it hasn't been added there

Also fix adding Uptime Kuma link source back.
@joyfinder
Copy link
Contributor Author

@joyfinder still, it hasn't been added there

Yes, I figured out what you meant, and checked my previous commit again.

Found out that I removed one's work before.

Re-fixed it back.

Thank you for the patience.

@rupali-codes rupali-codes linked an issue Oct 15, 2024 that may be closed by this pull request
3 tasks
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @joyfinder, looks good to me

@rupali-codes rupali-codes merged commit 2feaff7 into rupali-codes:main Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Might take time to finish goal: new-category Addition of new categories related contributions goal: new-feature New feature or request priority: high Making completely new feature priority: low Addition of new links/categories or doing any small task (e.g fixing typos)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add a new tool link in Devtools category
2 participants