Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation errors with some feature combinations #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FreezyLemon
Copy link

v_frame is only included when diff and/or estimate is enabled:

av1-grain/Cargo.toml

Lines 26 to 33 in f0292b0

[features]
default = ["create", "parse", "diff", "estimate"]
unstable = []
create = []
diff = ["num-rational", "v_frame"]
estimate = ["v_frame"]
parse = ["nom"]
serialize = ["serde", "arrayvec/serde"]

src/util.rs is only used with diff enabled at the moment.

I checked with cargo hack --feature-powerset check that this compiles

@coveralls
Copy link

coveralls commented Mar 31, 2024

Pull Request Test Coverage Report for Build 8501393001

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 26.517%

Totals Coverage Status
Change from base Build 7409066287: -0.001%
Covered Lines: 555
Relevant Lines: 2093

💛 - Coveralls

Copy link
Member

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants