-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update dependencies (Cargo.toml
)
#478
chore: Update dependencies (Cargo.toml
)
#478
Conversation
@matthiasbeyer I've been granted maintainer rights to
After that burst of activity, I don't think I can continue to assist maintaining the project much. I've got too many commitments to handle already 😅 |
Yes, I requested you to be added! I saw that you're doing a lot of stuff and I didn't want to slow you down by slow reviews and merges! So go ahead and do what you think is necessary! |
Ah, to amend on the above (and because it also came up elsewhere): I care a lot about clean commit history (as you probably already noted). That means, please don't do squash merges, not even for single-commit-PRs. And do not remove the gitlint CI job. I know it can be annoying to care about all the details to make it green, but IMHO it is worth it. Besides that, feel free to take this project to new highs! Especially as I have only been a passive maintainer (except for the config-rs-ng stuff). 😆 |
This comment was marked as off-topic.
This comment was marked as off-topic.
For reference, in the recent PR I reviewed ( |
This comment was marked as off-topic.
This comment was marked as off-topic.
Consistently omit patch version. Signed-off-by: Brennan Kinney <[email protected]>
6b369ba
to
078be9a
Compare
Rebased and will merge if CI is green. |
Consistently omit patch version.
Package notes:
lazy_static
to1.4
(note that this crate is deprecated officially, in favor ofonce_cell
).warp
:=
in Nov 2021 due to concern with MSRVwarp
maintainer.warp
MSRV was 1.51 at the time, which is also when "const generics" feature was introduced (March 2021).serde
andlazy_static
were repeated indev-dependencies
for some reason in Dec 2021. That also addednotify
with the^
qualifier, but this is the implicit default and stripped away from dependencies in this project some time ago.Outdated (not likely helpful)
UPDATE: This information may not be that useful to anyone else, hence the collapsed section. It's mostly been superseded by what I learned when preparing #495
Other MSRV history since the March 2022
warp
reference:config-rs
documented a version bump of MSRV from 1.49 to 1.56 (Nov 2021).config-rs
bumped MSRV from 1.60 to 1.64 (Sep 2022) due to dev-dependencytemp-env
.config-rs
bumped MSRV again to 1.66 (Dec 2022), with no documented reason for the requirement this time.You may want to update
Cargo.toml
to communicate MSRV better viarust-version
.rust-version
. At the very least, the real MSRV required for published crate should be identified, perhaps viacargo-msrv
?AFAIK, the patch versions have been set often without bumping, and without any actual requirement to make that the minimum patch version. So they are not actually serving much purpose.
Initially I misunderstood these to implicitly be
=
(fixed), hence the original motivation of the PR. As that's not the case, this does raiselazy_static
to1.4
as a minimum, which could be reverted.lazy_static
last released1.4
in Aug 2019, so I don't consider that a concern.EDIT:
major.minor
semver dependency of their own, and that dependency later pushing out a point release with a feature only stabilized since Rust1.71
(July 2023), which leaked through toconfig-rs
CI catching the failure (but could just as easily slipped through like forrust-ini
if the timing was a little later with theordered-multimap
crate patch release? 🤷♂️ )ahash
too (upstream issue), but since resolved.Additionally, the(EDIT:version
field is set to0.13.1
, while crates reports0.13.3
?0.13.x
is maintained via a separate branch, related PR raised)Another possible update is the
edition
to 2021 🤷♂️