-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to allow building with latest Rust version #31
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is awesome thanks a lot! Can you fix the remaining issue? The CI must be green I can't just leave a ❎ like that
@@ -18,7 +18,7 @@ include = ["src/**/*.rs", "tests/fixtures/*.img", "README.md", "LICENSE.Apache-2 | |||
|
|||
[dependencies] | |||
bitvec = "1.0.1" | |||
bincode = "1.0.1" | |||
serde = { version = "1.0.116", features = ["derive"] } | |||
serde-big-array = ">= 0.4.1, < 0.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this shouldn't be upgraded now. Can you check the different versions to see which ones work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you think it shouldn't be upgraded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I meant the opposite. Should this be upgraded too, to 0.6 or up idk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no 0.6, 0.5.1 is the latest (https://docs.rs/serde-big-array/latest/serde_big_array/).
There we go, clippy warnings fixed |
Ah, so that's why. Up to @cecton whether to bump the MSRV or to go back down to a 1.x bincode version, which I assume would work on the latest Rust still. |
Yes I guess since bincode 2 is still just a release candidate, we can't really make a stable release of mbrman like that. Once they finally release it then we can |
It seems fine for a stable release, given it's just legacy bincode 1 code, it would just require upping the MSRV to match bincode 2's MSRV |
Rust changing features broke proc, which broke any crates or dependencies using it. This PR simply updates to the latest version of each dependency to fix this issue.
Changes:
I ran all tests, no errors.