added lychee config and workflow, fix #718, fix #722

.github/workflows/check-links.yml

@@ -0,0 +1,52 @@
+name: Links
+
+on:
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  linkChecker:
+    runs-on: ubuntu-latest
+    env:
+      GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      CACHE_KEY: cache-lychee-${{ github.sha }}
+    permissions:
+      pull-requests: write
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Restore lychee cache
+        id: restore-cache
+        uses: actions/cache@v4
+        with:
+          path: .lycheecache
+          key: ${{ env.CACHE_KEY }}
+          restore-keys: cache-lychee-
+
+      - name: Link Checker
+        id: lychee
+        uses: lycheeverse/lychee-action@v2
+        with:
+          fail: false
+          output: ./lychee/out.md
+          args: "--base . --config ./ci/lychee.toml ."
+
+      - name: Save lychee cache
+        uses: actions/cache/save@v4
+        if: always()
+        with:
+          path: .lycheecache
+          key: ${{ steps.restore-cache.outputs.cache-primary-key || env.CACHE_KEY }} # fallback in case the cache wasn't created yet
+
+      - name: Post Comment on Pull Request
+        if: github.event_name == 'pull_request' && steps.lychee.outputs.exit_code != 0
+        run: |
+          echo "The link checker found some issues. Please review the report below:" > comment.md
+          echo "" >> comment.md
+          cat ./lychee/out.md >> comment.md
+          gh pr comment ${{ github.event.pull_request.number }} --body-file comment.md
+
+      - name: Fail Workflow
+        if: github.event_name == 'pull_request' && steps.lychee.outputs.exit_code != 0
+        run: exit 1

CONTRIBUTING.md

@@ -257,13 +257,11 @@ after the code sample.
 > generator [`rand::Rng`].
 >
 > The [distributions available are documented here][rand-distributions].
-> An example using the [`Normal`] distribution is shown below.
 
 [uniform distribution]: https://en.wikipedia.org/wiki/Uniform_distribution_(continuous)
 [`Distribution::sample`]: https://docs.rs/rand/*/rand/distributions/trait.Distribution.html#tymethod.sample
 [`rand::Rng`]: https://docs.rs/rand/*/rand/trait.Rng.html
 [rand-distributions]: https://docs.rs/rand/*/rand/distributions/index.html
-[`Normal`]: https://docs.rs/rand/*/rand/distributions/struct.Normal.html
 
 #### Code
 

README.md

@@ -1,7 +1,6 @@
 # A Rust Cookbook   [![Build Status travis]][travis]
 
 [Build Status travis]: https://api.travis-ci.com/rust-lang-nursery/rust-cookbook.svg?branch=master
-[travis]: https://travis-ci.com/rust-lang-nursery/rust-cookbook
 
 **[Read it here]**.
 

ci/dictionary.txt

@@ -348,4 +348,4 @@ YYYY
 zurich
 enum
 thiserror
-tempfile
+tempfile

ci/lychee.toml

@@ -0,0 +1,32 @@
+# Don't show interactive progress bar while checking links.
+no_progress = true
+
+# Enable link caching. This can be helpful to avoid checking the same links on
+# multiple runs.
+cache = true
+
+# Discard all cached requests older than this duration.
+max_cache_age = "2d"
+
+user_agent = "curl/7.83. 1"
+
+# Website timeout from connect to response finished.
+timeout = 20
+
+# Minimum wait time in seconds between retries of failed requests.
+retry_wait_time = 20
+
+# Comma-separated list of accepted status codes for valid links.
+accept = ["200", "429"] # 429 for ratelimits 
+
+# Request method
+method = "get"
+
+# Custom request headers
+headers = []
+
+# Exclude loopback IP address range and localhost from checking.
+exclude_loopback = false
+
+# Check mail addresses
+include_mail = true

src/cryptography/hashing/hmac.md

@@ -2,8 +2,9 @@
 
 [![ring-badge]][ring] [![cat-cryptography-badge]][cat-cryptography]
 
-Uses [`ring::hmac`] to creates a [`hmac::Signature`] of a string then verifies the signature is correct.
-
+The [`hmac::sign`] method is used to calculate the HMAC digest (also called a tag) of the message using the provided key.
+The resulting [`hmac::Tag`] structure contains the raw bytes of the HMAC,
+which can later be verified with[`hmac::verify`] to ensure the message has not been tampered with and comes from a trusted source.
 
 ```rust,edition2018
 use ring::{hmac, rand};
@@ -17,12 +18,17 @@ fn main() -> Result<(), Unspecified> {
     let key = hmac::Key::new(hmac::HMAC_SHA256, &key_value);
 
     let message = "Legitimate and important message.";
-    let signature = hmac::sign(&key, message.as_bytes());
+    let signature: hmac::Tag = hmac::sign(&key, message.as_bytes());
     hmac::verify(&key, message.as_bytes(), signature.as_ref())?;
 
     Ok(())
 }
 ```
 
-[`hmac::Signature`]: https://briansmith.org/rustdoc/ring/hmac/struct.Signature.html
-[`ring::hmac`]: https://briansmith.org/rustdoc/ring/hmac/
+[`ring::hmac`]: https://docs.rs/ring/*/ring/hmac/index.html
+
+[`hmac::sign`]: https://docs.rs/ring/*/ring/hmac/fn.sign.html
+
+[`hmac::Tag`]: https://docs.rs/ring/*/ring/hmac/struct.Tag.html
+
+[`hmac::verify`]: https://docs.rs/ring/*/ring/hmac/fn.verify.html

src/development_tools/debugging/config_log/log-custom.md

@@ -47,6 +47,6 @@ fn main() -> Result<()> {
 ```
 
 [`log4rs::append::file::FileAppender`]: https://docs.rs/log4rs/*/log4rs/append/file/struct.FileAppender.html
-[`log4rs::config::Config`]: https://docs.rs/log4rs/*/log4rs/config/struct.Config.html
+[`log4rs::config::Config`]: https://docs.rs/log4rs/*/log4rs/config/runtime/struct.Config.html
 [`log4rs::encode::pattern`]: https://docs.rs/log4rs/*/log4rs/encode/pattern/index.html
 [`log::LevelFilter`]: https://docs.rs/log/*/log/enum.LevelFilter.html

src/encoding/string/url-encode.md

@@ -23,7 +23,7 @@ fn main() {
 }
 ```
 
-[`form_urlencoded::byte_serialize`]: https://docs.rs/url/*/url/form_urlencoded/fn.byte_serialize.html
-[`form_urlencoded::parse`]: https://docs.rs/url/*/url/form_urlencoded/fn.parse.html
+[`form_urlencoded::byte_serialize`]: https://docs.rs//fn.byte_serialize.html
+[`form_urlencoded::parse`]: https://docs.rs/form_urlencoded/*/form_urlencoded/fn.parse.html
 
 [application/x-www-form-urlencoded]: https://url.spec.whatwg.org/#application/x-www-form-urlencoded

src/intro.md

@@ -4,7 +4,7 @@ This _Rust Cookbook_ is a collection of
 simple examples that demonstrate good practices to accomplish common
 programming tasks, using the crates of the Rust ecosystem.
 
-[Read more about _Rust Cookbook_](about.html), including tips for
+[Read more about _Rust Cookbook_](about.md), including tips for
 how to read the book, how to use the examples, and notes on conventions.
 
 ## Contributing

src/web/scraping/broken.md

@@ -6,7 +6,7 @@ Call `get_base_url` to retrieve the base URL. If the document has a base tag,
 get the href [`attr`] from base tag. [`Position::BeforePath`] of the original
 URL acts as a default.
 
-Iterates through links in the document and creates a [`tokio::spawn`] task that will 
+Iterates through links in the document and creates a [`tokio::task::spawn`] task that will 
 parse an individual link with [`url::ParseOptions`] and [`Url::parse`]). 
 The task makes a request to the links with [reqwest] and verifies
 [`StatusCode`].  Then the tasks `await` completion before ending the program.
@@ -28,6 +28,6 @@ fn main() -> anyhow::Result<()> {
 [`attr`]: https://docs.rs/select/*/select/node/struct.Node.html#method.attr
 [`Position::BeforePath`]: https://docs.rs/url/*/url/enum.Position.html#variant.BeforePath
 [`StatusCode`]: https://docs.rs/reqwest/*/reqwest/struct.StatusCode.html
-[`tokio::spawn`]: https://docs.rs/tokio/*/tokio/fn.spawn.html
+[`tokio::task::spawn`]: https://docs.rs/tokio/*/tokio/task/fn.spawn.html
 [`url::Parse`]: https://docs.rs/url/*/url/struct.Url.html#method.parse
 [`url::ParseOptions`]: https://docs.rs/url/*/url/struct.ParseOptions.html

xtask/src/tests.rs

@@ -31,14 +31,17 @@ fn run_all_tests() -> Result<(), Box<dyn Error>> {
     if !failures.is_empty() {
         println!("\n--- Test Summary ---");
         for name in failures {
-            println!("❌ {name} failed! Re-run with the command:");
-            println!("   cargo xtask test {name}");
+            eprintln!("❌ {name} failed! Re-run with the command:");
+            eprintln!("   cargo xtask test {name}");
         }
+        Err(Box::new(std::io::Error::new(
+            std::io::ErrorKind::Other,
+            "test failed",
+        )))
     } else {
         println!("\n🎉 All tests passed!");
+        Ok(())
     }
-
-    Ok(())
 }
 
 fn cargo_test() -> Result<(), Box<dyn Error>> {
@@ -87,12 +90,8 @@ fn link_checker() -> Result<(), Box<dyn Error>> {
         .current_dir(project_root())
         .args([
             "./book",
-            "--retry-wait-time",
-            "20",
-            "--max-retries",
-            "3",
-            "--accept",
-            "429", // accept 429 (ratelimit) errors as valid
+            "--config",
+            "./ci/lychee.toml"
         ])
         .status()?;