Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Mac Catalyst in CI, and clean up unnecessary iOS env flags #681

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Nov 20, 2024

Mac Catalyst is a technology that allows macOS to emulate or closely mimic iOS in behaviour. Let's use that in CI, as a proxy for real testing on iOS.

Also, rustc will figure out the SDK itself nowadays, so calling xcrun should be unnecessary.

@workingjubilee
Copy link
Member

The workflow is not valid. .github/workflows/main.yml (Line: 173, Col: 14): Unexpected symbol: '('. Located at position 23 within expression: matrix.target.contains('macabi') && '' || '--no-run'

rustc will figure out the SDK itself nowadays, so calling xcrun is
unnecessary.
@workingjubilee workingjubilee force-pushed the mac-catalyst branch 2 times, most recently from 9237721 to 9494ca6 Compare January 3, 2025 00:33
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the GHA syntax. Thanks!

@workingjubilee workingjubilee merged commit a9c4658 into rust-lang:master Jan 3, 2025
41 checks passed
@madsmtm madsmtm deleted the mac-catalyst branch January 3, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants