Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abs_diff function to SimdInt and SimdUint traits #429

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

okaneco
Copy link
Contributor

@okaneco okaneco commented Aug 25, 2024

Implement abs_diff for signed and unsigned integer vectors

@calebzulawski
Copy link
Member

calebzulawski commented Aug 25, 2024

Thank you! Can you move the test under the macros that generate all of the int/uint tests? That will allow the function to be fuzzed over all the types/lane counts/inputs. I think you can copy another test that takes 2 inputs.

@calebzulawski
Copy link
Member

I think it would be the same as this:

fn copysign<const LANES: usize>() {

However, it should be under the signed and unsigned tests, not float.

@okaneco
Copy link
Contributor Author

okaneco commented Aug 25, 2024

Thanks, I'll give that a try

Implement `abs_diff` for signed and unsigned integer vectors
@okaneco
Copy link
Contributor Author

okaneco commented Aug 25, 2024

Removed the original test file I added
Added the tests to impl_signed_tests and impl_unsigned_tests

With that advice, it was easy to add the tests

@calebzulawski
Copy link
Member

Looks good, thanks!

@calebzulawski calebzulawski merged commit 4697d39 into rust-lang:master Aug 25, 2024
57 checks passed
@okaneco okaneco deleted the abs_diff branch August 25, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants