Fix build of nix flake on aarch64-darwin #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deemp
reviewed
Apr 16, 2024
| @@ -22,7 +22,7 @@ | |||
|
|
|||
| rzk = "rzk"; | |||
| rzk-js = "rzk-js"; | |||
| ghcVersion = "ghc962"; | |||
| ghcVersion = "ghc963"; | |||
There was a problem hiding this comment.
Probably 964 will also be OK.
There was a problem hiding this comment.
Can we maybe even use 9.6.5? It has been released yesterday :)
There was a problem hiding this comment.
I don't think it's in nixpkgs just yet
There was a problem hiding this comment.
It's in nixpkgs, but I suggest we wait some time (#182), then update again. The nixpkgs version in this PR is OK for now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded the nixpkgs revision to more recent to include fixes (NixOS/nixpkgs#258280) to most haskell packages not building on aarch64-darwin.
Also updated ghc to 9.6.3 as it seems 9.6.2 was dropped from nixpkgs along the way(?)