prep for release

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: rotor
 Title: Log Rotation and Conditional Backups
-Version: 0.3.2
+Version: 0.3.3
 Authors@R: 
     person(given = "Stefan",
            family = "Fleck",
@@ -27,6 +27,7 @@ Suggests:
     rmarkdown,
     testthat,
     uuid,
+    ulid,
     zip
 Encoding: UTF-8
 LazyData: true

NEWS.md

@@ -1,5 +1,12 @@
 # rotor 0.3.2
 
+* Hotfix for some tests related to the `Cache` R6 class that fail on systems
+  with low-precision file system timestamps (such as ext3 and old Windows
+  file systems)
+
+
+# rotor 0.3.2
+
 * fixes time zone related issue in `Cache$prune()`.
 * fixes bug in `rotate_rds(on_change_only = TRUE)` that occurs if a version
   of data.table < 1.3.0 is installed and either the source or target object are a 

cran-comments.md

@@ -10,12 +10,9 @@
 
 0 errors | 0 warnings | 0 notes
 
-Sorry for the many resubmissions. This package currently has an issue that
-only to occur on macOS. It does not occur on the same macOS version available
-on Rhub. 
+Another - hopefully final attempt - to fix a hard to debug issue where some
+tests can fail on systems with low-precission filesystem-timestamps 
+(such as ext3 and old Windows filesystems).
 
-My current theory is that the error is caused by the accuracy of the
-'mtime' filestamp, which is linked to the file system the machine uses. 
-I implemented a workaround under that assumption, but I cannot be 100% sure 
-that this fixes that error. If the error still persists... could you please
-inform me which file system you use on r-release-macos-x86_64?
+Added a test that mocks low-precision filesystem-timestamps to be on the safe
+side.

tests/testthat/test_Cache.R

@@ -60,14 +60,14 @@ test_that("setting hash functions work", {
   expect_identical(cache_hash$n, 0L)
 
 
-  # To override this behaviour use a generate for unique ids, such as
+  # To override this behaviour use a function that generates globally unique ids instead of hashes
   cache_uid <- Cache$new(td, hashfun = function(x) ascending_id())
   cache_uid$push(iris)
   cache_uid$push(iris)
   expect_identical(cache_hash$n, 2L)
   cache_hash$purge()
 
-  # ensure hashfun allways returns a scalar
+  # fail if hashfun does not returns a scalar
   cache_err <- Cache$new(td, hashfun = function(x) c(ascending_id(),  ascending_id()))
   expect_error(cache_err$push(iris), class = "ValueError")
 })
@@ -86,6 +86,7 @@ test_that("pruning works by number of files works", {
   k3 <- cache$push(cars)
   expect_identical(cache$n, 3L)
 
+  # cached files are sorted in the order of their creation
   expect_identical(cache$files$key[[1]], k1)
   expect_identical(cache$files$key[[2]], k2)
   expect_identical(cache$files$key[[3]], k3)
@@ -98,7 +99,7 @@ test_that("pruning works by number of files works", {
 
 
 
-test_that("pruning works by number of files sorts by key if timestamp are identical", {
+test_that("$files is ordered by key if timestamps are identical", {
   td <- file.path(tempdir(), "cache-test")
   on.exit(unlink(td, recursive = TRUE))