Skip to content

Commit

Permalink
Delete two TExecutor Map signatures.
Browse files Browse the repository at this point in the history
Interface pruning leftovers: They weren't implemented. Also fixed a warning
  • Loading branch information
xvallspl authored and lmoneta committed Nov 4, 2016
1 parent d52ad59 commit 295f8b4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
6 changes: 1 addition & 5 deletions core/thread/inc/ROOT/TExecutor.hxx
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
#ifndef ROOT_TExecutor
#define ROOT_TExecutor

#include "TCollection.h"
#include "ROOT/TSeq.hxx"
#include <vector>

namespace ROOT {

Expand All @@ -31,13 +31,9 @@ public:
// //and a compile-time check that the argument list implements a front() method (all STL sequence containers have it)
template<class F, class Cond = noReferenceCond<F>>
auto Map(F func, unsigned nTimes) -> std::vector<typename std::result_of<F()>::type>;
template<class F, class T, class Cond = noReferenceCond<F, typename T::value_type>>
auto Map(F func, T &args) -> std::vector < decltype(++(args.begin()), args.end(), func(args.front()))>;
// /// \cond doxygen should ignore these methods
template<class F, class INTEGER, class Cond = noReferenceCond<F, INTEGER>>
auto Map(F func, ROOT::TSeq<INTEGER> args) -> std::vector<typename std::result_of<F(INTEGER)>::type>;
template<class F, class Cond = noReferenceCond<F, TObject*>>
auto Map(F func, TCollection &args) -> std::vector<typename std::result_of<F(TObject*)>::type>;
template<class F, class T, class Cond = noReferenceCond<F, T>>
auto Map(F func, std::initializer_list<T> args) -> std::vector<typename std::result_of<F(T)>::type>;
template<class F, class T, class Cond = noReferenceCond<F, T>>
Expand Down
2 changes: 1 addition & 1 deletion core/thread/inc/ROOT/TThreadExecutor.hxx
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private:
template<class T>
class ParallelReductionResolver{
public:
static inline T Reduce(TThreadExecutor *threadExecutor, const std::vector<T> &objs, const std::function<T(T a, T b)> &redfunc){
static inline T Reduce(TThreadExecutor *, const std::vector<T> &objs, const std::function<T(T a, T b)> &redfunc){
return std::accumulate(objs.begin(), objs.end(), T{}, redfunc);
}
};
Expand Down

0 comments on commit 295f8b4

Please sign in to comment.