Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filterBy crash when searching 'ui' string #1861

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: filterBy crash when searching 'ui' string #1861

wants to merge 1 commit into from

Conversation

pixelastronauts
Copy link

Issue

Entering 'ui' in the search box crashes the component due to:

  • filterBy receives UI object instead of string when searching 'ui'
  • Attempts toLowerCase() on object reference fails
  • Affects only the specific search term 'ui'

Fix

  • Ensures string conversion before toLowerCase operation
  • Handles edge case of UI object reference
  • Zero-impact change for other search terms

Testing

  • Verified 'ui' search string works without error
  • Confirmed other search terms behave normally

@pixelastronauts
fix: handle UI object in filterBy string conversion
9914f4a 
Ensures proper string conversion of label parameter in filterBy to handle UI objects.
Resolves issue with toLocaleLowerCase() failing on non-string values.
@pixelastronauts pixelastronauts changed the title Fix: filterBy crash when searching 'ui' string fix: filterBy crash when searching 'ui' string Jan 8, 2025
@pixelastronauts pixelastronauts mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pixelastronauts