Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Commit

Permalink
workaround needed for building Sage 8.9 due to changes in the fflas-f…
Browse files Browse the repository at this point in the history
…fpack spkg-install

as noted in the comment we need a mechanism for specifying any special
build flags on a per-version basis, though right now realistically we
only ever build the latest version--no one clamors for new builds of
older Sage versions
  • Loading branch information
embray committed Oct 9, 2019
1 parent 6c6e4fa commit 43bb6f1
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -55,22 +55,25 @@ SAGE_ROOT_RUNTIME=$(ENV_RUNTIME_DIR)$(SAGE_ROOT)

N_CPUS=$(shell cat /proc/cpuinfo | grep '^processor' | wc -l)

# Note: Be very careful about quoting here; we need literal
# TODO: These variables should be made dependent on the Sage version being
# built, as we may need to change this from version to version. In practice
# though we usually just care about building the latest version.
# NOTE: The latest version, 8.8, still does not work with system GMP.
SAGE_CONFIGURE_FLAGS:=--with-blas=atlas --with-mp=mpir

# NOTE: Be very careful about quoting here; we need literal
# quotes or else they will be stripped when exec'ing bash
# NOTE: FFLAS_FFPACK_CONFIGURE is needed to work around a regression introduced
# in Sage 8.9: https://trac.sagemath.org/ticket/27444#comment:34
SAGE_ENVVARS:=\
SAGE_NUM_THREADS=$(N_CPUS) \
SAGE_INSTALL_CCACHE=yes \
CCACHE_DIR=\"$(HOME)/.ccache\" \
SAGE_FAT_BINARY=yes \
SAGE_ATLAS_LIB=/lib \
FFLAS_FFPACK_CONFIGURE=--disable-openmp \
MAKE=\"make -j$(N_CPUS)\"

# TODO: This shoud be made dependent on the Sage version being built, as we may
# need to change this from version to version. In practice though we usually
# just care about building the latest version.
# Note: The latest version, 8.8, still does not work with system GMP.
SAGE_CONFIGURE_FLAGS:=--with-blas=atlas --with-mp=mpir

# Outputs representing success in the Sage build process
SAGE_CONFIGURE=$(SAGE_ROOT_BUILD)/configure
SAGE_MAKEFILE=$(SAGE_ROOT_BUILD)/build/make/Makefile
Expand Down

0 comments on commit 43bb6f1

Please sign in to comment.