-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the organisation name #51
Conversation
Change the organisation name to sailfishos-applications. Also change the QSettings objects to use the application organisation name.
Move the cache, settings and database from the old locations to the new ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with my quite limited C++ knowledge and experience.
My points are:
The second option would be to use
Thank you, that you did write quite some migration code: This is really nice to users. 😃 |
Did we discuss that sufficiently in your opinion? If this is fine for you, I will merge this PR tonight. |
Sorry, I didn't reply. I'm fine with your arguments. No objection ! I just wanted to be sure that the decision was clear and its pros and cons discussed. It seems it is. So let's go… |
Change the organisation name to
sailfishos-applications
. Also change the QSettings objects to use the application organisation name.Add some code to automatically migrate the data from the old directories to the new ones, defined by #21 and by changing the organisation name.
This should fix #50.
Before accepting this MR, we need to agree on the organisation name. Your proposition to use the github location looks fine. I'm just wondering if the code would be used one day outside of Sailfish (need to rewrite the UI, I know...), does this organisation name still makes sense ? Migration code are a bit error prone to write :-/